-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: use mock leaf in create tree test #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use mock leaf in create tree test #316
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @AvivYossef-starkware and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 70.45% 70.31% -0.15%
==========================================
Files 38 38
Lines 2109 2109
Branches 2109 2109
==========================================
- Hits 1486 1483 -3
- Misses 553 556 +3
Partials 70 70 ☔ View full report in Codecov by Sentry. |
Benchmark movements: full_committer_flow performance improved 😺 |
bd88982
to
d96d5f8
Compare
c7fe4b1
to
fbdf828
Compare
Benchmark movements: |
d96d5f8
to
9de23da
Compare
fbdf828
to
6f115fe
Compare
9de23da
to
1e92f7b
Compare
6f115fe
to
102c92d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware)
crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree_test.rs
line 206 at r1 (raw file):
#[values(true, false)] compare_modified_leaves: bool, ) { use crate::patricia_merkle_tree::internal_test_utils::OriginalSkeletonMockTrieConfig;
move to top of file
Code quote:
use crate::patricia_merkle_tree::internal_test_utils::OriginalSkeletonMockTrieConfig;
crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree_test.rs
line 430 at r1 (raw file):
(leaf.get_db_key(&leaf.0.to_bytes_be()), leaf.serialize()) } pub(crate) fn create_compiled_class_leaf_entry(val: u128) -> (StorageKey, StorageValue) {
restore the newline
Code quote:
}
pub(crate) fn create_compiled_class_leaf_entry(val: u128) -> (StorageKey, StorageValue) {
1e92f7b
to
6d9b95d
Compare
102c92d
to
1b3c352
Compare
1b3c352
to
f8fbe2f
Compare
Benchmark movements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 22 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)
crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree_test.rs
line 206 at r1 (raw file):
Previously, dorimedini-starkware wrote…
move to top of file
Done.
crates/committer/src/patricia_merkle_tree/original_skeleton_tree/create_tree_test.rs
line 430 at r1 (raw file):
Previously, dorimedini-starkware wrote…
restore the newline
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 22 files at r2, 21 of 21 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
This change is